Upgrade 1-11.38

main/gradebook/lib/be/abstractlink.class.php

@@ -633,18 +633,23 @@ abstract class AbstractLink implements GradebookItem
      */
     public static function getCurrentUserRanking($userId, $studentList)
     {
+        $previousScore = null;
         $ranking = null;
+        $position = null;
         $currentUserId = $userId;
         if (!empty($studentList) && !empty($currentUserId)) {
             $studentList = array_map('floatval', $studentList);
-            asort($studentList);
-            $ranking = $count = count($studentList);
-
-            foreach ($studentList as $userId => $position) {
+            arsort($studentList);
+            $count = count($studentList);
+            foreach ($studentList as $userId => $score) {
+                $position++;
+                if ($previousScore === null || $score < $previousScore) {
+                    $ranking = $position;
+                }
+                $previousScore = $score;
                 if ($currentUserId == $userId) {
                     break;
                 }
-                $ranking--;
             }
 
             // If no ranking was detected.

main/gradebook/lib/be/category.class.php

@@ -128,12 +128,9 @@ class Category implements GradebookItem
         return $this->weight;
     }
 
-    /**
-     * @return bool
-     */
-    public function is_locked()
+    public function is_locked(): bool
     {
-        return isset($this->locked) && $this->locked == 1 ? true : false;
+        return isset($this->locked) && $this->locked == 1;
     }
 
     /**
@@ -429,7 +426,7 @@ class Category implements GradebookItem
      * @param bool   $order_by    Whether to show all "session"
      *                            categories (true) or hide them (false) in case there is no session id
      *
-     * @return array
+     * @return array<int, Category>
      */
     public static function load(
         $id = null,
@@ -439,7 +436,7 @@ class Category implements GradebookItem
         $visible = null,
         $session_id = null,
         $order_by = null
-    ) {
+    ): array {
         //if the category given is explicitly 0 (not null), then create
         // a root category object (in memory)
         if (isset($id) && (int) $id === 0) {
@@ -2681,10 +2678,7 @@ class Category implements GradebookItem
         return $this->weight - $subWeight;
     }
 
-    /**
-     * @return Category
-     */
-    private static function create_root_category()
+    private static function create_root_category(): Category
     {
         $cat = new Category();
         $cat->set_id(0);
@@ -2704,9 +2698,9 @@ class Category implements GradebookItem
     /**
      * @param Doctrine\DBAL\Driver\Statement|null $result
      *
-     * @return array
+     * @return array<int, Category>
      */
-    private static function create_category_objects_from_sql_result($result)
+    private static function create_category_objects_from_sql_result($result): array
     {
         $categories = [];
         $allow = api_get_configuration_value('allow_gradebook_stats');

main/gradebook/lib/be/evaluation.class.php

@@ -221,7 +221,7 @@ class Evaluation implements GradebookItem
      * @param int    $category_id parent category
      * @param int    $visible     visible
      *
-     * @return array
+     * @return array<int, Evaluation>
      */
     public static function load(
         $id = null,
@@ -230,7 +230,7 @@ class Evaluation implements GradebookItem
         $category_id = null,
         $visible = null,
         $locked = null
-    ) {
+    ): array {
         $table = Database::get_main_table(TABLE_MAIN_GRADEBOOK_EVALUATION);
         $sql = 'SELECT * FROM '.$table;
         $paramcount = 0;
@@ -935,9 +935,9 @@ class Evaluation implements GradebookItem
     /**
      * @param array $result
      *
-     * @return array
+     * @return array<int, Evaluation>
      */
-    private static function create_evaluation_objects_from_sql_result($result)
+    private static function create_evaluation_objects_from_sql_result($result): array
     {
         $alleval = [];
         $allow = api_get_configuration_value('allow_gradebook_stats');

main/gradebook/lib/be/forumthreadlink.class.php

@@ -93,7 +93,7 @@ class ForumThreadLink extends AbstractLink
         $sql = "SELECT count(*) AS number FROM $table
                 WHERE
                     c_id = ".$this->course_id." AND
-                    thread_id = '".$this->get_ref_id()."'                    
+                    thread_id = '".$this->get_ref_id()."'
                 ";
         $result = Database::query($sql);
         $number = Database::fetch_row($result);
@@ -122,8 +122,8 @@ class ForumThreadLink extends AbstractLink
 
         $sql = 'SELECT thread_qualify_max
                 FROM '.Database::get_course_table(TABLE_FORUM_THREAD)."
-                WHERE 
-                    c_id = ".$this->course_id." AND 
+                WHERE
+                    c_id = ".$this->course_id." AND
                     thread_id = '".$this->get_ref_id()."'
                     $sessionCondition
                 ";
@@ -131,8 +131,8 @@ class ForumThreadLink extends AbstractLink
         $assignment = Database::fetch_array($query);
 
         $sql = "SELECT * FROM $thread_qualify
-                WHERE 
-                    c_id = ".$this->course_id." AND 
+                WHERE
+                    c_id = ".$this->course_id." AND
                     thread_id = ".$this->get_ref_id()."
                     $sessionCondition
                 ";
@@ -265,9 +265,9 @@ class ForumThreadLink extends AbstractLink
     {
         $sessionId = $this->get_session_id();
         $sql = 'SELECT count(id) from '.$this->get_forum_thread_table().'
-                WHERE 
-                    c_id = '.$this->course_id.' AND 
-                    thread_id = '.$this->get_ref_id().' AND 
+                WHERE
+                    c_id = '.$this->course_id.' AND
+                    thread_id = '.$this->get_ref_id().' AND
                     session_id='.$sessionId;
         $result = Database::query($sql);
         $number = Database::fetch_row($result);
@@ -281,8 +281,8 @@ class ForumThreadLink extends AbstractLink
         //it was extracts the forum id
         $sql = 'SELECT * FROM '.$this->get_forum_thread_table()."
                 WHERE
-                    c_id = '.$this->course_id.' AND 
-                    thread_id = '".$this->get_ref_id()."' AND 
+                    c_id = ".$this->course_id." AND
+                    thread_id = ".$this->get_ref_id()." AND
                     session_id = $sessionId ";
         $result = Database::query($sql);
         $row = Database::fetch_array($result, 'ASSOC');
@@ -304,7 +304,7 @@ class ForumThreadLink extends AbstractLink
         $ref_id = $this->get_ref_id();
 
         if (!empty($ref_id)) {
-            $sql = 'UPDATE '.$this->get_forum_thread_table().' SET 
+            $sql = 'UPDATE '.$this->get_forum_thread_table().' SET
                     thread_weight='.api_float_val($weight).'
                     WHERE c_id = '.$this->course_id.' AND thread_id= '.$ref_id;
             Database::query($sql);
@@ -344,9 +344,9 @@ class ForumThreadLink extends AbstractLink
 
         if (!isset($this->exercise_data)) {
             $sql = 'SELECT * FROM '.$this->get_forum_thread_table().'
-                    WHERE 
-                        c_id = '.$this->course_id.' AND  
-                        thread_id = '.$this->get_ref_id().' AND 
+                    WHERE
+                        c_id = '.$this->course_id.' AND
+                        thread_id = '.$this->get_ref_id().' AND
                         '.$session_condition;
             $query = Database::query($sql);
             $this->exercise_data = Database::fetch_array($query);

main/gradebook/lib/be/result.class.php

@@ -85,9 +85,9 @@ class Result
      * @param $user_id user id (student)
      * @param $evaluation_id evaluation where this is a result for
      *
-     * @return array
+     * @return array<int, Result>
      */
-    public static function load($id = null, $user_id = null, $evaluation_id = null)
+    public static function load($id = null, $user_id = null, $evaluation_id = null): array
     {
         $tbl_user = Database::get_main_table(TABLE_MAIN_USER);
         $tbl_grade_results = Database::get_main_table(TABLE_MAIN_GRADEBOOK_RESULT);