Upgrade 1-11.38

plugin/ims_lti/ImsLtiPlugin.php

@@ -486,7 +486,13 @@ class ImsLtiPlugin extends Plugin
             throw new Exception($this->get_lang('NoAccessToUrl'));
         }
 
-        $xml = new SimpleXMLElement($content);
+        libxml_use_internal_errors(true);
+        $xml = simplexml_load_string($content, SimpleXMLElement::class, LIBXML_NONET);
+
+        if ($xml === false) {
+            throw new Exception($this->get_lang('LaunchUrlNotFound'));
+        }
+
         $result = $xml->xpath('blti:launch_url');
 
         if (empty($result)) {
@@ -718,7 +724,10 @@ class ImsLtiPlugin extends Plugin
             return null;
         }
 
-        return new SimpleXMLElement($request);
+        libxml_use_internal_errors(true);
+        $xml = simplexml_load_string($request, SimpleXMLElement::class, LIBXML_NONET);
+
+        return $xml !== false ? $xml : null;
     }
 
     /**

plugin/ims_lti/README.md

@@ -25,6 +25,7 @@ external tool.
 
 # Installation
 
+* Make sure PHP's [OpenSSL extension](https://www.php.net/manual/en/openssl.installation.php) is available on your server
 * Prepare your web server to allow to send cookies in all contexts, set the `SameSite` attribute to `None`
     * i.e. Apache configuration
 

plugin/ims_lti/lang/english.php

@@ -75,3 +75,4 @@ $strings['ReplacementUserIdHelp'] = 'The current user_id (sub) in launch params
 $strings['AddInCourses'] = 'Add in courses';
 $strings['AddInAllCourses'] = 'Add in all courses';
 $strings['AddInSessions'] = 'Add in sessions';
+$strings["BaseToolsCanBeAddedInSessionsOnly"] = "Base tools can be added in sessions only";

plugin/ims_lti/lang/french.php

@@ -75,3 +75,4 @@ $strings['ReplacementUserIdHelp'] = 'Le user_id (sub) actuel dans les paramètre
 $strings['AddInCourses'] = 'Ajouter aux cours';
 $strings['AddInAllCourses'] = 'Ajouter à tous les cours';
 $strings['AddInSessions'] = 'Ajouter aux sessions';
+$strings["BaseToolsCanBeAddedInSessionsOnly"] = "Les outils de base peuvent uniquement être ajoutés dans les sessions";

plugin/ims_lti/lang/spanish.php

@@ -75,3 +75,4 @@ $strings['ReplacementUserIdHelp'] = 'El user_id (sub) actual en los parametros d
 $strings['AddInCourses'] = 'Añadir a cursos';
 $strings['AddInAllCourses'] = 'Aãndir a todos los cursos';
 $strings['AddInSessions'] = 'Añadir a sesiones';
+$strings["BaseToolsCanBeAddedInSessionsOnly"] = "Las herramientas base pueden ser añadidas únicamente en sesiones";

plugin/ims_lti/multiply_session.php

@@ -32,13 +32,13 @@ try {
     }
 
     if ($tool->getParent()) {
-        throw new Exception($plugin->get_lang('NoAllowed'));
+        throw new Exception($plugin->get_lang('BaseToolsCanBeAddedInSessionsOnly'));
     }
 
     $session = api_get_session_entity($sessionId);
 
     if (!$session) {
-        api_not_allowed(true);
+        throw new Exception(get_lang('Session not found.'));
     }
 
     $content = '';
@@ -71,7 +71,7 @@ try {
             'multiple' => true,
         ]
     );
-    $form->addCheckBox('tool_visible', get_lang('SetVisible'), get_lang('ToolIsNowVisible'));
+    $form->addCheckBox('tool_visible', get_lang('Set visible'), get_lang('The tool is now visible.'));
     $form->addButtonExport(get_lang('Save'));
 
     if ($form->validate()) {

plugin/ims_lti/session.php

@@ -31,7 +31,7 @@ try {
     }
 
     if ($tool->getParent()) {
-        throw new Exception($plugin->get_lang('NoAllowed'));
+        throw new Exception($plugin->get_lang('BaseToolsCanBeAddedInSessionsOnly'));
     }
 
     $content = '';
@@ -60,7 +60,7 @@ try {
 
         if (!$formValues['sessions']) {
             Display::addFlash(
-                Display::return_message($plugin->get_lang('NeedToSelectASession'), 'error', false)
+                Display::return_message(get_lang('Session not found.'), 'error', false)
             );
             header('Location:'.api_get_self());
             exit;