Upgrade 1-11.38

vendor/symfony/security-acl/Tests/Voter/AclVoterTest.php

@@ -11,29 +11,29 @@
 
 namespace Symfony\Component\Security\Acl\Tests\Voter;
 
-use Symfony\Component\Security\Acl\Exception\NoAceFoundException;
-use Symfony\Component\Security\Acl\Voter\FieldVote;
-use Symfony\Component\Security\Acl\Exception\AclNotFoundException;
+use Symfony\Component\Security\Acl\Domain\ObjectIdentity;
 use Symfony\Component\Security\Acl\Domain\RoleSecurityIdentity;
 use Symfony\Component\Security\Acl\Domain\UserSecurityIdentity;
-use Symfony\Component\Security\Acl\Domain\ObjectIdentity;
-use Symfony\Component\Security\Core\Authorization\Voter\VoterInterface;
+use Symfony\Component\Security\Acl\Exception\AclNotFoundException;
+use Symfony\Component\Security\Acl\Exception\NoAceFoundException;
 use Symfony\Component\Security\Acl\Voter\AclVoter;
+use Symfony\Component\Security\Acl\Voter\FieldVote;
+use Symfony\Component\Security\Core\Authorization\Voter\VoterInterface;
 
-class AclVoterTest extends \PHPUnit_Framework_TestCase
+class AclVoterTest extends \PHPUnit\Framework\TestCase
 {
     /**
      * @dataProvider getSupportsAttributeTests
      */
     public function testSupportsAttribute($attribute, $supported)
     {
-        list($voter, , $permissionMap) = $this->getVoter(true, false);
+        [$voter, , $permissionMap] = $this->getVoter(true, false);
 
         $permissionMap
             ->expects($this->once())
             ->method('contains')
             ->with($this->identicalTo($attribute))
-            ->will($this->returnValue($supported))
+            ->willReturn($supported)
         ;
 
         $this->assertSame($supported, $voter->supportsAttribute($attribute));
@@ -44,27 +44,27 @@ class AclVoterTest extends \PHPUnit_Framework_TestCase
      */
     public function testSupportsAttributeNonString($attribute)
     {
-        list($voter) = $this->getVoter(true, false);
+        [$voter] = $this->getVoter(true, false);
 
         $this->assertFalse($voter->supportsAttribute($attribute));
     }
 
     public function getSupportsAttributeTests()
     {
-        return array(
-            array('foo', true),
-            array('foo', false),
-        );
+        return [
+            ['foo', true],
+            ['foo', false],
+        ];
     }
 
     public function getSupportsAttributeNonStringTests()
     {
-        return array(
-            array(new \stdClass()),
-            array(1),
-            array(true),
-            array(array()),
-        );
+        return [
+            [new \stdClass()],
+            [1],
+            [true],
+            [[]],
+        ];
     }
 
     /**
@@ -72,30 +72,30 @@ class AclVoterTest extends \PHPUnit_Framework_TestCase
      */
     public function testSupportsClass($class)
     {
-        list($voter) = $this->getVoter();
+        [$voter] = $this->getVoter();
 
         $this->assertTrue($voter->supportsClass($class));
     }
 
     public function getSupportsClassTests()
     {
-        return array(
-            array('foo'),
-            array('bar'),
-            array('moo'),
-        );
+        return [
+            ['foo'],
+            ['bar'],
+            ['moo'],
+        ];
     }
 
     public function testVote()
     {
-        list($voter, , $permissionMap) = $this->getVoter();
+        [$voter, , $permissionMap] = $this->getVoter();
         $permissionMap
             ->expects($this->atLeastOnce())
             ->method('getMasks')
-            ->will($this->returnValue(null))
+            ->willReturn(null)
         ;
 
-        $this->assertSame(VoterInterface::ACCESS_ABSTAIN, $voter->vote($this->getToken(), null, array('VIEW', 'EDIT', 'DELETE')));
+        $this->assertSame(VoterInterface::ACCESS_ABSTAIN, $voter->vote($this->getToken(), null, ['VIEW', 'EDIT', 'DELETE']));
     }
 
     /**
@@ -103,11 +103,11 @@ class AclVoterTest extends \PHPUnit_Framework_TestCase
      */
     public function testVoteWhenNoObjectIsPassed($allowIfObjectIdentityUnavailable)
     {
-        list($voter, , $permissionMap) = $this->getVoter($allowIfObjectIdentityUnavailable);
+        [$voter, , $permissionMap] = $this->getVoter($allowIfObjectIdentityUnavailable);
         $permissionMap
             ->expects($this->once())
             ->method('getMasks')
-            ->will($this->returnValue(array()))
+            ->willReturn([])
         ;
 
         if ($allowIfObjectIdentityUnavailable) {
@@ -116,7 +116,7 @@ class AclVoterTest extends \PHPUnit_Framework_TestCase
             $vote = VoterInterface::ACCESS_ABSTAIN;
         }
 
-        $this->assertSame($vote, $voter->vote($this->getToken(), null, array('VIEW')));
+        $this->assertSame($vote, $voter->vote($this->getToken(), null, ['VIEW']));
     }
 
     /**
@@ -124,17 +124,17 @@ class AclVoterTest extends \PHPUnit_Framework_TestCase
      */
     public function testVoteWhenOidStrategyReturnsNull($allowIfUnavailable)
     {
-        list($voter, , $permissionMap, $oidStrategy) = $this->getVoter($allowIfUnavailable);
+        [$voter, , $permissionMap, $oidStrategy] = $this->getVoter($allowIfUnavailable);
         $permissionMap
             ->expects($this->once())
             ->method('getMasks')
-            ->will($this->returnValue(array()))
+            ->willReturn([])
         ;
 
         $oidStrategy
             ->expects($this->once())
             ->method('getObjectIdentity')
-            ->will($this->returnValue(null))
+            ->willReturn(null)
         ;
 
         if ($allowIfUnavailable) {
@@ -143,34 +143,34 @@ class AclVoterTest extends \PHPUnit_Framework_TestCase
             $vote = VoterInterface::ACCESS_ABSTAIN;
         }
 
-        $this->assertSame($vote, $voter->vote($this->getToken(), new \stdClass(), array('VIEW')));
+        $this->assertSame($vote, $voter->vote($this->getToken(), new \stdClass(), ['VIEW']));
     }
 
     public function getTrueFalseTests()
     {
-        return array(array(true), array(false));
+        return [[true], [false]];
     }
 
     public function testVoteNoAclFound()
     {
-        list($voter, $provider, $permissionMap, $oidStrategy, $sidStrategy) = $this->getVoter();
+        [$voter, $provider, $permissionMap, $oidStrategy, $sidStrategy] = $this->getVoter();
 
         $permissionMap
             ->expects($this->once())
             ->method('getMasks')
-            ->will($this->returnValue(array()))
+            ->willReturn([])
         ;
 
         $oidStrategy
             ->expects($this->once())
             ->method('getObjectIdentity')
-            ->will($this->returnValue($oid = new ObjectIdentity('1', 'Foo')))
+            ->willReturn($oid = new ObjectIdentity('1', 'Foo'))
         ;
 
         $sidStrategy
             ->expects($this->once())
             ->method('getSecurityIdentities')
-            ->will($this->returnValue($sids = array(new UserSecurityIdentity('johannes', 'Foo'), new RoleSecurityIdentity('ROLE_FOO'))))
+            ->willReturn($sids = [new UserSecurityIdentity('johannes', 'Foo'), new RoleSecurityIdentity('ROLE_FOO')])
         ;
 
         $provider
@@ -180,7 +180,7 @@ class AclVoterTest extends \PHPUnit_Framework_TestCase
             ->will($this->throwException(new AclNotFoundException('Not found.')))
         ;
 
-        $this->assertSame(VoterInterface::ACCESS_DENIED, $voter->vote($this->getToken(), new \stdClass(), array('VIEW')));
+        $this->assertSame(VoterInterface::ACCESS_DENIED, $voter->vote($this->getToken(), new \stdClass(), ['VIEW']));
     }
 
     /**
@@ -188,39 +188,39 @@ class AclVoterTest extends \PHPUnit_Framework_TestCase
      */
     public function testVoteGrantsAccess($grant)
     {
-        list($voter, $provider, $permissionMap, $oidStrategy, $sidStrategy) = $this->getVoter();
+        [$voter, $provider, $permissionMap, $oidStrategy, $sidStrategy] = $this->getVoter();
 
         $permissionMap
             ->expects($this->once())
             ->method('getMasks')
             ->with($this->equalTo('VIEW'))
-            ->will($this->returnValue($masks = array(1, 2, 3)))
+            ->willReturn($masks = [1, 2, 3])
         ;
 
         $oidStrategy
             ->expects($this->once())
             ->method('getObjectIdentity')
-            ->will($this->returnValue($oid = new ObjectIdentity('1', 'Foo')))
+            ->willReturn($oid = new ObjectIdentity('1', 'Foo'))
         ;
 
         $sidStrategy
             ->expects($this->once())
             ->method('getSecurityIdentities')
-            ->will($this->returnValue($sids = array(new UserSecurityIdentity('johannes', 'Foo'), new RoleSecurityIdentity('ROLE_FOO'))))
+            ->willReturn($sids = [new UserSecurityIdentity('johannes', 'Foo'), new RoleSecurityIdentity('ROLE_FOO')])
         ;
 
         $provider
             ->expects($this->once())
             ->method('findAcl')
             ->with($this->equalTo($oid), $this->equalTo($sids))
-            ->will($this->returnValue($acl = $this->getMock('Symfony\Component\Security\Acl\Model\AclInterface')))
+            ->willReturn($acl = $this->createMock('Symfony\Component\Security\Acl\Model\AclInterface'))
         ;
 
         $acl
             ->expects($this->once())
             ->method('isGranted')
             ->with($this->identicalTo($masks), $this->equalTo($sids), $this->isFalse())
-            ->will($this->returnValue($grant))
+            ->willReturn($grant)
         ;
 
         if ($grant) {
@@ -229,37 +229,37 @@ class AclVoterTest extends \PHPUnit_Framework_TestCase
             $vote = VoterInterface::ACCESS_DENIED;
         }
 
-        $this->assertSame($vote, $voter->vote($this->getToken(), new \stdClass(), array('VIEW')));
+        $this->assertSame($vote, $voter->vote($this->getToken(), new \stdClass(), ['VIEW']));
     }
 
     public function testVoteNoAceFound()
     {
-        list($voter, $provider, $permissionMap, $oidStrategy, $sidStrategy) = $this->getVoter();
+        [$voter, $provider, $permissionMap, $oidStrategy, $sidStrategy] = $this->getVoter();
 
         $permissionMap
             ->expects($this->once())
             ->method('getMasks')
             ->with($this->equalTo('VIEW'))
-            ->will($this->returnValue($masks = array(1, 2, 3)))
+            ->willReturn($masks = [1, 2, 3])
         ;
 
         $oidStrategy
             ->expects($this->once())
             ->method('getObjectIdentity')
-            ->will($this->returnValue($oid = new ObjectIdentity('1', 'Foo')))
+            ->willReturn($oid = new ObjectIdentity('1', 'Foo'))
         ;
 
         $sidStrategy
             ->expects($this->once())
             ->method('getSecurityIdentities')
-            ->will($this->returnValue($sids = array(new UserSecurityIdentity('johannes', 'Foo'), new RoleSecurityIdentity('ROLE_FOO'))))
+            ->willReturn($sids = [new UserSecurityIdentity('johannes', 'Foo'), new RoleSecurityIdentity('ROLE_FOO')])
         ;
 
         $provider
             ->expects($this->once())
             ->method('findAcl')
             ->with($this->equalTo($oid), $this->equalTo($sids))
-            ->will($this->returnValue($acl = $this->getMock('Symfony\Component\Security\Acl\Model\AclInterface')))
+            ->willReturn($acl = $this->createMock('Symfony\Component\Security\Acl\Model\AclInterface'))
         ;
 
         $acl
@@ -269,7 +269,7 @@ class AclVoterTest extends \PHPUnit_Framework_TestCase
             ->will($this->throwException(new NoAceFoundException('No ACE')))
         ;
 
-        $this->assertSame(VoterInterface::ACCESS_DENIED, $voter->vote($this->getToken(), new \stdClass(), array('VIEW')));
+        $this->assertSame(VoterInterface::ACCESS_DENIED, $voter->vote($this->getToken(), new \stdClass(), ['VIEW']));
     }
 
     /**
@@ -277,39 +277,39 @@ class AclVoterTest extends \PHPUnit_Framework_TestCase
      */
     public function testVoteGrantsFieldAccess($grant)
     {
-        list($voter, $provider, $permissionMap, $oidStrategy, $sidStrategy) = $this->getVoter();
+        [$voter, $provider, $permissionMap, $oidStrategy, $sidStrategy] = $this->getVoter();
 
         $permissionMap
             ->expects($this->once())
             ->method('getMasks')
             ->with($this->equalTo('VIEW'))
-            ->will($this->returnValue($masks = array(1, 2, 3)))
+            ->willReturn($masks = [1, 2, 3])
         ;
 
         $oidStrategy
             ->expects($this->once())
             ->method('getObjectIdentity')
-            ->will($this->returnValue($oid = new ObjectIdentity('1', 'Foo')))
+            ->willReturn($oid = new ObjectIdentity('1', 'Foo'))
         ;
 
         $sidStrategy
             ->expects($this->once())
             ->method('getSecurityIdentities')
-            ->will($this->returnValue($sids = array(new UserSecurityIdentity('johannes', 'Foo'), new RoleSecurityIdentity('ROLE_FOO'))))
+            ->willReturn($sids = [new UserSecurityIdentity('johannes', 'Foo'), new RoleSecurityIdentity('ROLE_FOO')])
         ;
 
         $provider
             ->expects($this->once())
             ->method('findAcl')
             ->with($this->equalTo($oid), $this->equalTo($sids))
-            ->will($this->returnValue($acl = $this->getMock('Symfony\Component\Security\Acl\Model\AclInterface')))
+            ->willReturn($acl = $this->createMock('Symfony\Component\Security\Acl\Model\AclInterface'))
         ;
 
         $acl
             ->expects($this->once())
             ->method('isFieldGranted')
             ->with($this->identicalTo('foo'), $this->identicalTo($masks), $this->equalTo($sids), $this->isFalse())
-            ->will($this->returnValue($grant))
+            ->willReturn($grant)
         ;
 
         if ($grant) {
@@ -318,37 +318,37 @@ class AclVoterTest extends \PHPUnit_Framework_TestCase
             $vote = VoterInterface::ACCESS_DENIED;
         }
 
-        $this->assertSame($vote, $voter->vote($this->getToken(), new FieldVote(new \stdClass(), 'foo'), array('VIEW')));
+        $this->assertSame($vote, $voter->vote($this->getToken(), new FieldVote(new \stdClass(), 'foo'), ['VIEW']));
     }
 
     public function testVoteNoFieldAceFound()
     {
-        list($voter, $provider, $permissionMap, $oidStrategy, $sidStrategy) = $this->getVoter();
+        [$voter, $provider, $permissionMap, $oidStrategy, $sidStrategy] = $this->getVoter();
 
         $permissionMap
             ->expects($this->once())
             ->method('getMasks')
             ->with($this->equalTo('VIEW'))
-            ->will($this->returnValue($masks = array(1, 2, 3)))
+            ->willReturn($masks = [1, 2, 3])
         ;
 
         $oidStrategy
             ->expects($this->once())
             ->method('getObjectIdentity')
-            ->will($this->returnValue($oid = new ObjectIdentity('1', 'Foo')))
+            ->willReturn($oid = new ObjectIdentity('1', 'Foo'))
         ;
 
         $sidStrategy
             ->expects($this->once())
             ->method('getSecurityIdentities')
-            ->will($this->returnValue($sids = array(new UserSecurityIdentity('johannes', 'Foo'), new RoleSecurityIdentity('ROLE_FOO'))))
+            ->willReturn($sids = [new UserSecurityIdentity('johannes', 'Foo'), new RoleSecurityIdentity('ROLE_FOO')])
         ;
 
         $provider
             ->expects($this->once())
             ->method('findAcl')
             ->with($this->equalTo($oid), $this->equalTo($sids))
-            ->will($this->returnValue($acl = $this->getMock('Symfony\Component\Security\Acl\Model\AclInterface')))
+            ->willReturn($acl = $this->createMock('Symfony\Component\Security\Acl\Model\AclInterface'))
         ;
 
         $acl
@@ -358,12 +358,12 @@ class AclVoterTest extends \PHPUnit_Framework_TestCase
             ->will($this->throwException(new NoAceFoundException('No ACE')))
         ;
 
-        $this->assertSame(VoterInterface::ACCESS_DENIED, $voter->vote($this->getToken(), new FieldVote(new \stdClass(), 'foo'), array('VIEW')));
+        $this->assertSame(VoterInterface::ACCESS_DENIED, $voter->vote($this->getToken(), new FieldVote(new \stdClass(), 'foo'), ['VIEW']));
     }
 
     public function testWhenReceivingAnObjectIdentityInterfaceWeDontRetrieveANewObjectIdentity()
     {
-        list($voter, $provider, $permissionMap, $oidStrategy, $sidStrategy) = $this->getVoter();
+        [$voter, $provider, $permissionMap, $oidStrategy, $sidStrategy] = $this->getVoter();
 
         $oid = new ObjectIdentity('someID', 'someType');
 
@@ -371,7 +371,7 @@ class AclVoterTest extends \PHPUnit_Framework_TestCase
             ->expects($this->once())
             ->method('getMasks')
             ->with($this->equalTo('VIEW'))
-            ->will($this->returnValue($masks = array(1, 2, 3)))
+            ->willReturn($masks = [1, 2, 3])
         ;
 
         $oidStrategy
@@ -382,14 +382,14 @@ class AclVoterTest extends \PHPUnit_Framework_TestCase
         $sidStrategy
             ->expects($this->once())
             ->method('getSecurityIdentities')
-            ->will($this->returnValue($sids = array(new UserSecurityIdentity('johannes', 'Foo'), new RoleSecurityIdentity('ROLE_FOO'))))
+            ->willReturn($sids = [new UserSecurityIdentity('johannes', 'Foo'), new RoleSecurityIdentity('ROLE_FOO')])
         ;
 
         $provider
             ->expects($this->once())
             ->method('findAcl')
             ->with($this->equalTo($oid), $this->equalTo($sids))
-            ->will($this->returnValue($acl = $this->getMock('Symfony\Component\Security\Acl\Model\AclInterface')))
+            ->willReturn($acl = $this->createMock('Symfony\Component\Security\Acl\Model\AclInterface'))
         ;
 
         $acl
@@ -399,34 +399,34 @@ class AclVoterTest extends \PHPUnit_Framework_TestCase
             ->will($this->throwException(new NoAceFoundException('No ACE')))
         ;
 
-        $voter->vote($this->getToken(), $oid, array('VIEW'));
+        $voter->vote($this->getToken(), $oid, ['VIEW']);
     }
 
     protected function getToken()
     {
-        return $this->getMock('Symfony\Component\Security\Core\Authentication\Token\TokenInterface');
+        return $this->createMock('Symfony\Component\Security\Core\Authentication\Token\TokenInterface');
     }
 
     protected function getVoter($allowIfObjectIdentityUnavailable = true, $alwaysContains = true)
     {
-        $provider = $this->getMock('Symfony\Component\Security\Acl\Model\AclProviderInterface');
-        $permissionMap = $this->getMock('Symfony\Component\Security\Acl\Permission\PermissionMapInterface');
-        $oidStrategy = $this->getMock('Symfony\Component\Security\Acl\Model\ObjectIdentityRetrievalStrategyInterface');
-        $sidStrategy = $this->getMock('Symfony\Component\Security\Acl\Model\SecurityIdentityRetrievalStrategyInterface');
+        $provider = $this->createMock('Symfony\Component\Security\Acl\Model\AclProviderInterface');
+        $permissionMap = $this->createMock('Symfony\Component\Security\Acl\Permission\PermissionMapInterface');
+        $oidStrategy = $this->createMock('Symfony\Component\Security\Acl\Model\ObjectIdentityRetrievalStrategyInterface');
+        $sidStrategy = $this->createMock('Symfony\Component\Security\Acl\Model\SecurityIdentityRetrievalStrategyInterface');
 
         if ($alwaysContains) {
             $permissionMap
                 ->expects($this->any())
                 ->method('contains')
-                ->will($this->returnValue(true));
+                ->willReturn(true);
         }
 
-        return array(
+        return [
             new AclVoter($provider, $oidStrategy, $sidStrategy, $permissionMap, null, $allowIfObjectIdentityUnavailable),
             $provider,
             $permissionMap,
             $oidStrategy,
             $sidStrategy,
-        );
+        ];
     }
 }